Load configuration lazily #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelgomesxyz
requested changes
Nov 23, 2023
rafaelgomesxyz
requested changes
Nov 24, 2023
justin808
reviewed
Nov 25, 2023
I have worked on something like this (as side work). I work on it more to see if that implementation can fix the issue. |
ahangarha
force-pushed
the
dont-read-config-files-for-some-commands
branch
from
7086b18 to
e9dde02
Compare
rafaelgomesxyz
requested changes
Nov 25, 2023
ahangarha
changed the title
ahangarha
force-pushed
the
dont-read-config-files-for-some-commands
branch
2 times, most recently
from
1127448 to
efa2865
Compare
In this commit, instead of having two config classes, we don't load configuration from file unless the command demand extended configuration.
This reverts commit e9dde02.
ahangarha
force-pushed
the
dont-read-config-files-for-some-commands
branch
from
efa2865 to
b88f712
Compare
rafaelgomesxyz
approved these changes
Dec 1, 2023
|
will be merged in #109 |
|
@justin808 We can update the #109 based on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables us to specify commands that don't need complete configuration from config files. With this, not only can we run commands like
cpl version,cpl --version, andcpl --help, we can add new commands likecpl generateto create basic file structure and config templates in a project where no Control Plane configurations exist.The implementation is not ideal, but it is good enough to be shared and discussed.This PR prevents loading configurations from files unless a command requests an extended configuration. Commands with
WITH_MINIMAL_CONFIGwon't make such a request, which makes it possible to define commands that can run without configuration files. For example:cpl --versioncpl --helpcpl generate(in future)Closes #93