Skip to content

Commit

Permalink
Merge branch 'dev'
Browse files Browse the repository at this point in the history
* dev:
  actions: attempt to fix upload assets
  DrawerHeaderView: use sentence case for name
  do not use FragmentContainerView in login
  • Loading branch information
shalzz committed Apr 20, 2020
2 parents df343a8 + 0404fdb commit 9ec01d2
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,16 @@ jobs:
draft: false
prerelease: false

- run: pwd
- run: ls
- run: tree ./
- name: Upload Release Asset
id: upload-release-asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: ./app/build/outputs/apk/release/app-release.apk
asset_path: $HOME/app/build/outputs/apk/release/app-release.apk
asset_name: college-academics-${{ github.ref }}.apk
asset_content_type: application/zip
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,11 @@ class MainActivity : BaseActivity(), MainMvpView, BillingProvider {
/******* MVP View methods implementation */

override fun updateUserDetails(user: User) {
val name = user.name.split(" ")
.joinToString(" ") { s -> s.toLowerCase().capitalize() }
if (user.name.isNotEmpty())
drawerHeaderVH!!.tvName.text = user.name
drawerHeaderVH!!.tvName.text = name
println(name)
if (user.course.isNotEmpty())
drawerHeaderVH!!.tvCourse.text = user.course
}
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/activity_login.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
android:background="?attr/colorPrimary"
android:theme="@style/ThemeOverlay.MaterialComponents.Dark.ActionBar"/>

<androidx.fragment.app.FragmentContainerView
<fragment
android:layout_width="match_parent"
android:layout_height="match_parent"
android:id="@+id/login_nav_host_fragment"
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/layout/drawer_header.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
android:layout_height="wrap_content"
android:layout_marginTop="28dp"
android:paddingTop="5dp"
android:paddingBottom="5dp"
android:text="Name"
android:textAppearance="?attr/textAppearanceHeadline6"
android:textSize="18sp" />
Expand All @@ -47,6 +48,7 @@
android:layout_height="wrap_content"
android:layout_below="@+id/drawer_header_name"
android:text="Course"
android:textAppearance="?attr/textAppearanceBody1"
android:textSize="13sp" />

<TextView
Expand Down

0 comments on commit 9ec01d2

Please sign in to comment.