Remove Multidex declaration #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the min SDK is 21, it is no longer necessary to use the Multidex library. See the following for more info: https://developer.android.com/build/multidex#mdex-on-l
MGaetan89
commented
Nov 10, 2024
| @@ -198,9 +197,6 @@ dependencies { | |||
| val NAV_VERSION = "2.7.1" | |||
| val BILLING_VERSION = "6.0.1" | |||
|
|
|||
| // TODO: re-evaluate when RxJava is completely replaced with kotlin co-routines | |||
There was a problem hiding this comment.
I wasn't sure what to check regarding this TODO. Let me know if I missed something
|
Ah, I've not been maintaining and updating the app any longer, but thanks for the PR! I guess you found this repo while trying to look up users of |
Exactly 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the min SDK is 21, it is no longer necessary to use the Multidex library.
See the following for more info: https://developer.android.com/build/multidex#mdex-on-l