Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the docker build script #192

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

cticenhour
Copy link
Member

With these changes the Dockerfile doesn't need to be updated manually. This is in preparation for a staged move to

  1. Automating MOOSE submodule updates from CIVET instead of dependabot, and then
  2. Automating the Docker build process through Docker Hub directly now that shannonlab is a proper Docker Team.

This PR also moves the Dockerfile to the scripts directory. It's not necessary to keep it in the root directory, so let's place it beside the script that actually uses it.

Refs #155

@cticenhour
Copy link
Member Author

Also adding a dependabot config update in 3014bf4 to go ahead and remove moose from submodule updates through that method.

@cticenhour
Copy link
Member Author

Docker precheck requirement has been removed from CIVET as of idaholab/civet_recipes#1217

@moosebuild
Copy link
Collaborator

moosebuild commented Apr 13, 2023

Job Documentation on 12ee59c wanted to post the following:

View the site here

This comment will be updated on new commits.

@cticenhour
Copy link
Member Author

@csdechant can you give this a review? Going to kick-off automated updates through CIVET after this makes it to the master branch.

@cticenhour cticenhour requested a review from csdechant April 14, 2023 18:34
@csdechant csdechant merged commit ed6b617 into shannon-lab:devel Apr 14, 2023
@cticenhour cticenhour deleted the improve-docker-build branch April 14, 2023 19:01
@cticenhour
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants