-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MOOSE and Crane submodules #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge when testing completes
Thanks @dschwen! |
Job Mac Test on 0452b45 : invalidated by @cticenhour Environment did not initialize correctly |
@cticenhour this uses an outdated libmesh conda package. The updated moose submodule has an updated libmesh submodule which should trigger a conda package rebuild. This might not be in your test recipe and you might have to wait until the libmesh conda package is released. This might happen once the changes in moose hit master (Jason will know that). |
Yes, you're right - I noticed after my invalidate. I won't get a libmesh package update for these recipes until those changes hit master. @milljm -- Do I need to temporarily allow Zapdos to fail on the |
Oh wow this is a good one...a Zapdos PR that depends on a MOOSE update which we can do because we have a MOOSE submodule...but that we can't do because we don't actually test against the libmesh hash that is in the MOOSE submodule... 🤣 |
More incentive to stop using conda libmesh for CIVET testing |
Or have a package generated earlier for a libmesh update and then used for testing, with the final channel transition occurring in master. I suppose that would require another channel? |
Wow, MOOSE update will depend on a PETSc submodule update that we can control since it is a moose submodule, but we can not since we do not test against the petsc submodule hash. So civet should stop using |
We should have ./update_and_rebuild_everything.sh that starts with gcc
submodule and finishes with libmesh :-)
…On Fri, May 29, 2020 at 8:42 AM Fande Kong ***@***.***> wrote:
Oh wow this is a good one...a Zapdos PR that depends on a MOOSE update
which we can do because we have a MOOSE submodule...but that we can't do
because we don't actually test against the libmesh hash that is in the
MOOSE submodule... 🤣
Wow, MOOSE update will depend on a PETSc submodule update that we can
control since it is a moose submodule, but we can not since we do not test
against the petsc submodule hash. So civet should stop using conda-petsc
🤣
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#62 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOGA4GN5VAPGQFQLYAYQETRT7JWRANCNFSM4NNMZ3JA>
.
|
I suppose you can revert the changes @cticenhour did to Zapdos civet recipes (so it does not use conda). I can do that if you all wish. |
:-( I guess so. I really like what you did with the "build Linux stack/build Mac stack" for MOOSE testing, but it probably doesn't make sense to do it for application testing...? Maybe it's just easier to build libmesh |
You could add an additional allowed to fail build with conda recipe. But for testing the submodule should be the gold standard. |
FYI the changes to Zapdos testing was reverted for now until a better solution for conda testing is in place. Invalidating to redo the testing. |
Intermittent failure in
Any idea why git is getting confused here? I should say it's not the first time I've seen it (we just had more important failures to deal with) |
After discussions with Jason, this seems to be a |
Closes #61