Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MOOSE and Crane submodules #62

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

dschwen
Copy link

@dschwen dschwen commented May 28, 2020

Closes #61

Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when testing completes

@cticenhour
Copy link
Member

Thanks @dschwen!

@moosebuild
Copy link
Collaborator

Job Mac Test on 0452b45 : invalidated by @cticenhour

Environment did not initialize correctly

@dschwen
Copy link
Author

dschwen commented May 28, 2020

@cticenhour this uses an outdated libmesh conda package. The updated moose submodule has an updated libmesh submodule which should trigger a conda package rebuild. This might not be in your test recipe and you might have to wait until the libmesh conda package is released. This might happen once the changes in moose hit master (Jason will know that).

@cticenhour
Copy link
Member

Yes, you're right - I noticed after my invalidate. I won't get a libmesh package update for these recipes until those changes hit master.

@milljm -- Do I need to temporarily allow Zapdos to fail on the External App Tests target so that these changes can move on to master (after the other failures are fixed)?

@lindsayad
Copy link
Member

Oh wow this is a good one...a Zapdos PR that depends on a MOOSE update which we can do because we have a MOOSE submodule...but that we can't do because we don't actually test against the libmesh hash that is in the MOOSE submodule... 🤣

@lindsayad
Copy link
Member

More incentive to stop using conda libmesh for CIVET testing

@cticenhour
Copy link
Member

Or have a package generated earlier for a libmesh update and then used for testing, with the final channel transition occurring in master. I suppose that would require another channel?

@fdkong
Copy link

fdkong commented May 29, 2020

Oh wow this is a good one...a Zapdos PR that depends on a MOOSE update which we can do because we have a MOOSE submodule...but that we can't do because we don't actually test against the libmesh hash that is in the MOOSE submodule... 🤣

Wow, MOOSE update will depend on a PETSc submodule update that we can control since it is a moose submodule, but we can not since we do not test against the petsc submodule hash. So civet should stop using conda-petsc 🤣

@lindsayad
Copy link
Member

lindsayad commented May 29, 2020 via email

@milljm
Copy link

milljm commented Jun 1, 2020

I suppose you can revert the changes @cticenhour did to Zapdos civet recipes (so it does not use conda).

I can do that if you all wish.

@lindsayad
Copy link
Member

:-( I guess so. I really like what you did with the "build Linux stack/build Mac stack" for MOOSE testing, but it probably doesn't make sense to do it for application testing...? Maybe it's just easier to build libmesh

@dschwen
Copy link
Author

dschwen commented Jun 1, 2020

You could add an additional allowed to fail build with conda recipe. But for testing the submodule should be the gold standard.

@lindsayad
Copy link
Member

image

@cticenhour
Copy link
Member

cticenhour commented Jun 1, 2020

FYI the changes to Zapdos testing was reverted for now until a better solution for conda testing is in place. Invalidating to redo the testing.

@cticenhour
Copy link
Member

cticenhour commented Jun 1, 2020

Intermittent failure in Mac Test occurs during Fetch and Branch:

BUILD_ROOT/zapdos/: git pull --no-ff [email protected]:dschwen/zapdos.git api_update_61
From github.com:dschwen/zapdos
 * branch            api_update_61 -> FETCH_HEAD
Fetching submodule crane
From github.com:lcpp-org/crane
   8a5fd5b..581cb44  master     -> origin/master
Fetching submodule moose
From github.com:idaholab/moose
   ce7162a053..0289ba37e8  devel      -> origin/devel
   10b79e5667..c4d71de1ea  master     -> origin/master
   e470dd3296..0f3c82da44  next       -> origin/next
 * [new branch]            revert-15355-deim-test-problem -> origin/revert-15355-deim-test-problem
Could not access submodule 'large_media'Fetching submodule moose/libmesh
fatal: cannot chdir to '../../../../../moose/libmesh': No such file or directory
fatal: cannot chdir to '../../../../../moose/libmesh': No such file or directory
Deleting repository in an attempt to fix an un-recoverable git issue
Removing /opt/civet/build_0/zapdos

Any idea why git is getting confused here? I should say it's not the first time I've seen it (we just had more important failures to deal with)

@cticenhour
Copy link
Member

After discussions with Jason, this seems to be a git issue happening on other PRs around MOOSE-land, not just Zapdos. I am going to merge.

@cticenhour cticenhour merged commit ac2e6c2 into shannon-lab:devel Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update moose and crane submodules after API change
6 participants