[WIP] Heavy species action #84
Conversation
…e math nicer looking
… implemented yet. May need to have two different function betweene electron and electron energy kernels
…ecies material blocks
Electron action
…ding each block type so far. Currently adds variables/aux_variables , kernels, and the material itself.
…n_test problem. Got rid of the Drift diffusion action. Slight disparity between the results of the drift action and the heavy species action.
…st runs. The greg_electron_and_heavy .e file shows the results from using the heavy species action and electron action in place of the drift diffusion action. Ran on action_test.i.
|
@cticenhour this PR is a work in progress; I'm not sure how to designate it as such. @ggolba2 is working with me to implement the changes suggested in Issue #73 . So far it only includes electron transport and heavy species transport. The heavy species transport action adds all of the drift-diffusion kernels along with the Material properties for each species. I'd like to open this up to discussion at this point because we are not sure how to deal with boundary conditions or interfacial conditions. We'd also like feedback on the structure of the ElectronTransport and HeavySpeciesTransport actions. This is all just a kind of "proof of concept" at this point, so the end result is definitely up for debate! |
@lindsayad beat me to it! 😄 Welcome @ggolba2! It's wonderful to see more developers. 😄 @keniley1 I may not be able to take a look at this until next week, as I've got a few dissertation things to get sorted this weekend. But I like that we're creating more actions! I want to give you an idea of a roadmap for the next little while that I've been working on with @csdechant:
After these two things are done, I think we'll be good to go with integrating this PR in. Does that sound OK to you? My electromagnetic changes are also on the way (the electromagnetic module in MOOSE should go live by early May), but I haven't determined an ETA for that yet. |
|
I forgot to mention a website upgrade in that roadmap! As you can see in #82, I'm making some infrastructure and website upgrades, with the hope being I can automate website updates moving forward. This will also require some documentation from you before this PR can be merged (we should probably have required this a while back 😅), but since this is WIP, just something to keep in mind for now. |
|
Alright, sounds good! There's definitely no rush on this PR. We're just testing some ideas for input file structure and we wanted to open it up to the community (which consists of you, Alex, and Corey at this point...) to see what would work for everyone. I expect there to be some modifications before this is ready to be integrated. |
|
@ggolba2 what's your affiliation? |
|
@lindsayad I'm an undergrad student in Prof. Curreli's group at UIUC. Nice to meet you all! |
|
Cool. Nice to meet you too!
…On Fri, Apr 16, 2021 at 1:29 PM ggolba2 ***@***.***> wrote:
@lindsayad <https://github.com/lindsayad> I'm an undergrad student in
Prof. Curreli's group at UIUC. Nice to meet you all!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOGA4CHXG46SP5KLDEBAFTTJCM4HANCNFSM43CAFXBA>
.
|
|
This PR will be closed due to inactivity for over 2 years. Thank you for your time and contribution! Please re-open if this feature will be worked on once again. |
Implemented actions for heavy species and electron transport as mentioned in issue #73 . The AddDriftDiffusionAction block is no longer used as these two new actions take care of the blocks AddDriftDiffusionAction would create. However, the heavy species and electron transport actions do not take account of secondary charge particles as of now. This still needs to be implemented. Action is still needed for adding boundary condition blocks as well.