SHARD-1386 : Harden relayer collector syncing #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulazeem-tk4vr
force-pushed
the
checkpoint
branch
from
718c6f8 to
fac3f75
Compare
| console.log('VERY SLOW QUERY', sql, time) | ||
| } | ||
| }) | ||
| // NOT SUPPORTED IN BETTER-SQLITE3 |
There was a problem hiding this comment.
what's an option for this? we may need to have some profiling
There was a problem hiding this comment.
we could make a db wrapper class than can proxy the run, prepare, all , etc calls to run the profiling. that way we wouldnt' need to replace all usages of db.x instead could just import our wrapper class as db = new WrapperDatabase and everything should still work
There was a problem hiding this comment.
maybe we address this in another ticket?
urnotsam
reviewed
Feb 3, 2025
src/class/validateData.ts
Outdated
| @@ -5,6 +5,7 @@ import { insertOrUpdateCycle } from '../storage/cycle' | |||
| import { processReceiptData } from '../storage/receipt' | |||
| import { processOriginalTxData } from '../storage/originalTxData' | |||
| import { CycleLogWriter, ReceiptLogWriter, OriginalTxDataLogWriter } from './DataLogWriter' | |||
| import * as checkpoint from '../storage/checkpoint' | |||
src/collector.ts
Outdated
| console.log('Attempting fix..') | ||
|
|
||
| // Starts the syncing process from the beginning | ||
| const status = await startPatching(0) |
There was a problem hiding this comment.
this is not correct right? it should start syncing from whatever checkpoint we have in DB.
I also hope we considered syncing last 100 cycles by default on restart @abdulazeem-tk4vr
…ts asynchronously
abdulazeem-tk4vr
force-pushed
the
checkpoint
branch
from
2f42801 to
e074b18
Compare
…ustness fix : add error logs fix: ensure start cycle does not go below zero in patching process
abdulazeem-tk4vr
force-pushed
the
checkpoint
branch
from
e074b18 to
f9b55f4
Compare
…or missing cycles
…w all data to be inserted in collector.
aniketdivekar
previously approved these changes
Feb 6, 2025
urnotsam
previously approved these changes
Feb 6, 2025
urnotsam
approved these changes
Feb 6, 2025
aniketdivekar
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linear: https://linear.app/shm/issue/SHARD-1386/harden-relayer-collector-syncing