Shm 3053(2) #10
Merged
Shm 3053(2) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEC-117 Put killroute endpoints behind debug middleware
See SHM-2555 for original findings Currently the endpoints involved with killing other nodes are considered debug endpoints but they are not tied to debug mode in the node. Its controlled via
|
…llowKillRoute variable as its redundant now
arhamj
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Add debugmiddleware to killroute endpoints * we refactored killroutes to be behind debug middleware. Removed the allowKillRoute variable as its redundant now --------- Co-authored-by: Sam Sweet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts killroute behind debug middleware and removes allowKillRoute flag