SHARD-1727 - Reintegrate ITN to dev #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. update node is not called every cycle for every node - its only called when there are changes. - in our case, a node being marked as refuted / lost does not trigger an updateNode call - solution: updateProblematicNodeTracking in updateNode + Sync::applyNodeListChange update 2. updateNode is not the best place to initialize refuteCycles, because then nodes will be added without it initialized - solution: initialize refuteCycles in addNode if the flag is on, dont check activationCycle 3. nodelist gossip is broken because it cant serialize Set properly - solution: change refuteCycles to be an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.