Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant words #369

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/network-state-hash.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ depth we are operating on (well, one down from what we are working to solve)
### implement and call shareNetworkStateHashes()

Next need a function shareNetworkStateHashes() this function is first must build out a plan
for which hashes will be sent to which nodes. Ideally we could have some cases where we are sending the same data and can do a multi-tell. It can get tricky to bucket things up. I suppose a simple way to do it is by concatenating the the ratix values that will be sent (sorted). This can be a key to a list of nodes that can take that given set of data along with an array of the non concatenated radix values. If we solve this in a "first pass" then we can make perfect buckets.
for which hashes will be sent to which nodes. Ideally we could have some cases where we are sending the same data and can do a multi-tell. It can get tricky to bucket things up. I suppose a simple way to do it is by concatenating the ratix values that will be sent (sorted). This can be a key to a list of nodes that can take that given set of data along with an array of the non concatenated radix values. If we solve this in a "first pass" then we can make perfect buckets.
The next pass will be to iterate through the bucket values above and and for each bucket build a message given the array of radix values we want to forward. Then do a multi tell to all the nodes in the list that will get this data.

### calculating coverage ranges in shareNetworkStateHashes
Expand Down
2 changes: 1 addition & 1 deletion src/p2p/Join/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1452,7 +1452,7 @@ function validateJoinRequestTimestamp(joinRequestTimestamp: number): JoinRequest
//TODO - figure out why joinRequest is send with previous cycle marker instead of current cycle marker
/*
CONTEXT: when node create join request the cycleMarker is (current - 1).
The reason join request didn't use current cycleMarker is most likely the the current cycle is potential not agreed upon yet.
The reason join request didn't use current cycleMarker is most likely the current cycle is potential not agreed upon yet.
but the joinRequestTimestamp is Date.now
so checking if the timestamp is within its cycleMarker is gurantee to fail
let request cycle marker be X, then X+1 is current cycle, then we check if the timestamp is in the current cycleMarker
Expand Down
2 changes: 1 addition & 1 deletion src/p2p/Lost.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1251,7 +1251,7 @@ async function isDownCheck(node) {
/* prettier-ignore */ nestedCountersInstance.countEvent('p2p', 'isDownCheck-down-1', 1)
return 'down'
}
//adding this check so that a node can repond that is is down. aka, realizes it is not funcitonal and wants to be removed from the network
//adding this check so that a node can repond that is down. aka, realizes it is not funcitonal and wants to be removed from the network
if (res.s === nodeDownString) {
/* prettier-ignore */ nestedCountersInstance.countEvent('p2p', 'isDownCheck-down-self-reported-zombie', 1)
return 'down'
Expand Down
2 changes: 1 addition & 1 deletion src/state-manager/AccountPatcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4036,7 +4036,7 @@ class AccountPatcher {

/* prettier-ignore */ nestedCountersInstance.countEvent(`accountPatcher`, `inSync again. ${Utils.safeStringify(this.syncFailHistory[this.syncFailHistory.length -1])}`)

//this is not really a fatal log so should be removed eventually. is is somewhat usefull context though when debugging.
//this is not really a fatal log so should be removed eventually. is somewhat usefull context though when debugging.
this.statemanager_fatal(`inSync again`, Utils.safeStringify(this.syncFailHistory))
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/state-manager/TransactionQueue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5683,7 +5683,7 @@ class TransactionQueue {

// For normal didSync===false TXs we are expiring them after M3*2
// This gives a bit of room to attempt a repair.
// if a repair or reciept process fails there are cases below to expire the the
// if a repair or reciept process fails there are cases below to expire the
// tx as early as time > M3
if (txAge > timeM3 * 2 && queueEntry.didSync == false) {
//this.statistics.incrementCounter('txExpired')
Expand Down Expand Up @@ -6379,7 +6379,7 @@ class TransactionQueue {
// 7. Manually request missing state
try {
nestedCountersInstance.countEvent('processing', 'data missing at t>M2. request data')
// Await note: current thinking is that is is best to not await this call.
// Await note: current thinking is that is best to not await this call.
this.queueEntryRequestMissingData(queueEntry)
} catch (ex) {
/* prettier-ignore */ if (logFlags.debug) this.mainLogger.debug('processAcceptedTxQueue2 queueEntryRequestMissingData:' + ex.name + ': ' + ex.message + ' at ' + ex.stack)
Expand Down
2 changes: 1 addition & 1 deletion src/state-manager/state-manager-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ export type AccountHashCache = {

/**
* History for a single account
* Recent history, and a index to to the last list it was written to
* Recent history, and a index to the last list it was written to
*/
export type AccountHashCacheHistory = {
lastSeenCycle: number
Expand Down