Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

red 62 red 63 #7

Merged
merged 0 commits into from
Apr 19, 2024
Merged

Conversation

afostr
Copy link
Contributor

@afostr afostr commented Apr 19, 2024

No description provided.

Copy link

linear bot commented Apr 19, 2024

RED-63 Fix issues with isNodeOutOfRoationBounds

ISSUE SUMMARY:

The naming of this function is leading to confusion in its usage. It sounds like this would return true if a node was rotating in/out, but it actually returns false in this case. We need to refactor this to use a clearer name and update existing references that may be using the negated expected value.


ISSUE REPRO STEPS:

<HINT: Add steps to list as-needed. If interaction is complex, add screenshots or a Slack screen-capture video (just drag and drop)>

  1. <<TODO: Replace with repro step Bump the npm_and_yarn group across 1 directory with 5 updates #1>>
  2. <<TODO: Replace with repro step BLUE-2: fix: receipt generation in case of challenge #2>>
  3. Observe <<TODO: Describe unintended behavior.>>

EXPECTED RESULT:

<<TODO: Replace this with your expected results.>>


MERGE REQUESTS:

<HINT: If your fix requires changes in multiple repos, add the following info per-repository.>

<<TODO: Enter Repository Name>>

Pull Request Link: <TODO: Insert PR-Link>

GPT Review Link: <<TODO: Insert GPT-Review-Link>>

Jenkins Test Link: <<TODO: Insert Jenkins Test Job Link>>


ADDITIONAL INSTRUCTIONS:

<HINT: Add any additional instructions needed for the assignee. If you have specific requirements for how the task should be implemented or fixed, enter them or link them here.>

<<TODO: Insert additional instructions for assignee.>>

@afostr afostr merged commit c2e6864 into dev Apr 19, 2024
2 checks passed
@mhanson-github mhanson-github deleted the red-63-fix-issues-with-isnodeoutofroationbounds branch August 17, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant