fix: Fixed a bug of parsing slides (#326)

shd101wyy · Oct 9, 2023 · c906f48 · c906f48
1 parent f4c9c12
commit c906f48
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,12 @@ Please visit https://github.com/shd101wyy/vscode-markdown-preview-enhanced/relea
 
 ## [Unreleased]
 
+## [0.8.21] - 2023-10-09
+
+### Bug fixes
+
+- Fixed a bug of rendering front-matter that caused the failure of rendering slides: https://github.com/shd101wyy/vscode-markdown-preview-enhanced/issues/1814
+
 ## [0.8.20] - 2023-10-09
 
 ### New features

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "crossnote",
-  "version": "0.8.20",
+  "version": "0.8.21",
   "description": "A powerful markdown notebook tool",
   "keywords": [
     "markdown"

diff --git a/src/markdown-engine/index.ts b/src/markdown-engine/index.ts
@@ -2607,7 +2607,13 @@ sidebarTOCBtn.addEventListener('click', function(event) {
     //   enhanceWithEmojiToSvg($);
     // }
 
-    html = frontMatterTable + $('head').html() + $('body').html(); // cheerio $.html() will add <html><head></head><body>$html</body></html>, so we hack it by select body first.
+    html =
+      frontMatterTable +
+      // NOTE: '\n' is necessary here. Otherwise, it might generate html like '</table><p data-source-line="12">[CROSSNOTESLIDE]</p>'
+      // and we will fail to parse for slides, which splits by `^<p...>[CROSSNOTESLIDE]</p>`.
+      '\n' +
+      $('head').html() +
+      $('body').html(); // cheerio $.html() will add <html><head></head><body>$html</body></html>, so we hack it by select body first.
 
     /**
      * check slides