Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore missing langs/*.mjs exports #882

Closed
wants to merge 2 commits into from

Conversation

RomanHotsiy
Copy link

Description

Fixes the breaking change in 1.25 related to shiki/langs/<lang>.mjs imports

Linked Issues

FIxes #881

Additional context

Fixes the breaking change in 1.25
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 04ad76e
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/677670f6e72e3e0008d2adb2
😎 Deploy Preview https://deploy-preview-882--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit dbc75cc
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/677670e491487600083c8adb
😎 Deploy Preview https://deploy-preview-882--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 04ad76e
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/677670f64c1c980008a1529b
😎 Deploy Preview https://deploy-preview-882--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RomanHotsiy
Copy link
Author

No idea why the CI is failing, most likely not related.

@RomanHotsiy RomanHotsiy changed the title Fix langs exports fix: restore missing langs/*.mjs exports Jan 2, 2025
@RomanHotsiy
Copy link
Author

Hey @antfu 🙌 .

Sorry to ping you directly but could you take a quick look 🙏 . We have a bunch of users not using the pinned version 😢 and have broken builds now.

@RomanHotsiy RomanHotsiy mentioned this pull request Jan 2, 2025
5 tasks
@antfu
Copy link
Member

antfu commented Jan 2, 2025

Which version are you using? 1.25.1? What error are you getting? It seems to work fine on my side. I don't think we touched the exports part

@RomanHotsiy
Copy link
Author

RomanHotsiy commented Jan 3, 2025

import vim from 'shiki/langs/vim.mjs';

Error:

image

@antfu
Copy link
Member

antfu commented Jan 3, 2025

Please provide a minimal reproduction. Thanks.

Why reproduction is required

@RomanHotsiy
Copy link
Author

Here is the repro: https://github.com/RomanHotsiy/shiki-bug-repro

@RomanHotsiy
Copy link
Author

UPDATE. It seems to be fixed on 1.26.1 in this commit: 5766b28

Thanks! Closing.

@RomanHotsiy RomanHotsiy closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential breaking change in 1.25
3 participants