Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific section for CDN and fix language and grammar #1151

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

Isengo1989
Copy link
Collaborator

@Isengo1989 Isengo1989 commented Oct 25, 2023

https://shopware.atlassian.net/browse/DX-438

Got a few requests already after updates from 6.4 to 6.5 - most often about the CDN config. To be ahead there was a specific config added for the old shopware.cdn.url config.

@Isengo1989 Isengo1989 marked this pull request as ready for review October 25, 2023 07:29
@Isengo1989 Isengo1989 added the Improvement PR created to append/modify info in the existing article label Oct 25, 2023
@Isengo1989 Isengo1989 merged commit c0e138a into main Oct 30, 2023
1 check passed
@Isengo1989 Isengo1989 deleted the dx-438/add-cdn-info branch October 30, 2023 12:51
Copy link
Contributor

@King-of-Babylon King-of-Babylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement PR created to append/modify info in the existing article
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants