-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update deployment best practices for DSR #1621
Merged
Isengo1989
merged 9 commits into
shopware:main
from
quando1910:feat/update-best-practice-dsr
Dec 20, 2024
Merged
feat: update deployment best practices for DSR #1621
Isengo1989
merged 9 commits into
shopware:main
from
quando1910:feat/update-best-practice-dsr
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quando1910
changed the title
feat: update the pipeline sample when deploy DSR template
feat: update deployment best practices for DSR
Dec 18, 2024
Isengo1989
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR @quando1910 🎉
Some small changes are suggested ✍️
products/digital-sales-rooms/best-practices/app-deployment/aws.md
Outdated
Show resolved
Hide resolved
products/digital-sales-rooms/best-practices/app-deployment/aws.md
Outdated
Show resolved
Hide resolved
products/digital-sales-rooms/best-practices/app-deployment/aws.md
Outdated
Show resolved
Hide resolved
products/digital-sales-rooms/best-practices/app-deployment/aws.md
Outdated
Show resolved
Hide resolved
products/digital-sales-rooms/best-practices/app-deployment/aws.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Micha Hobert <[email protected]>
Co-authored-by: Micha Hobert <[email protected]>
Co-authored-by: Micha Hobert <[email protected]>
Co-authored-by: Micha Hobert <[email protected]>
Co-authored-by: Micha Hobert <[email protected]>
Isengo1989
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.