Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #1622

Closed
wants to merge 1 commit into from
Closed

Update index.md #1622

wants to merge 1 commit into from

Conversation

mboelt
Copy link
Contributor

@mboelt mboelt commented Dec 19, 2024

Please prevent the usage of !important statements in your storefront templates.

Please prevent the usage of !important statements in your storefront templates.
@Isengo1989 Isengo1989 self-requested a review December 19, 2024 08:02
@Isengo1989
Copy link
Collaborator

@mboelt the headline of the paragraph is "Do not use inline CSS" and the new info states not to use "!important" in templates.

Isn't this obsolete then or is it meant for the scss files not to be used in?

@mboelt
Copy link
Contributor Author

mboelt commented Dec 19, 2024

Good point. Maybe it is clearer with this one:
Please prevent the usage of !important statements in your storefront CSS.

@Isengo1989
Copy link
Collaborator

Good point. Maybe it is clearer with this one: Please prevent the usage of !important statements in your storefront CSS.

I would suggest to put it under an own heading or make the headline more generic, otherwise this is a bit confusing (headline states inline)

Also noticed that app and plugin is switched in the two articles

image

I can update it if you want

@mboelt
Copy link
Contributor Author

mboelt commented Jan 2, 2025

Please feel free to do so. I appreciate.

@Isengo1989
Copy link
Collaborator

https://github.com/shopware/docs/pull/1638/files

@Isengo1989 Isengo1989 closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants