Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line about required checks #1642

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Add line about required checks #1642

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01ed7cd
Add line about required checks
pweyck Jan 10, 2025
7223a1b
Update resources/guidelines/code/contribution.md
sushmangupta Jan 15, 2025
98a125a
Merge branch 'main' into add-line-about-required-checks
sushmangupta Jan 15, 2025
9f5eca9
Merge branch 'main' into add-line-about-required-checks
sushmangupta Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions resources/guidelines/code/contribution.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ You are responsible for maintaining and updating your pull request. This include
* Updating the code according to review feedback
* Keeping the PR up to date with the target branch if conflicts arise
* Making sure that all pipeline checks succeed on your PR
* We only have one required job called `check`. The job just makes sure that all integration tests are passing. It uses the action [`re-actors/alls-green`](https://github.com/re-actors/alls-green)

::: tip
Once your PR is public, avoid rebasing or force-pushing to the branch. Adding new commits makes it easier for reviewers to track changes and see what was updated in response to feedback. The PR will be automatically squashed when merged.
Expand Down
Loading