Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract sidebar (DevHub) and cleanup config #1313

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

bojanrajh
Copy link
Contributor

@bojanrajh bojanrajh commented Sep 24, 2024

Description

This PR is a start of breaking down #493 into smaller chunks:

  • extracts themeConfig.sidebar into sidebar.ts so DevHub can pick statically defined sidebar in/from this repo
  • removes duplicate vitepress config already defined in baseConfig

Type of change

Non-breaking change.

ToDo's

/

Additional context

Shortcuts in package.json, .github workflows, missing articles (so we can turn on deadlink detection) and custom hook for plugins ("typer") will be added/migrated in a separate PRs.

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Sep 24, 2024 11:50am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Sep 24, 2024 11:50am

@mdanilowicz mdanilowicz self-requested a review September 24, 2024 10:58
@BrocksiNet BrocksiNet merged commit 7057884 into main Sep 24, 2024
7 checks passed
@BrocksiNet BrocksiNet deleted the dx/cleanup-docs-config branch September 24, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants