Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-gen): allow multiple json overrides for schema #1566

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Jan 7, 2025

Description

closes #1466

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Jan 7, 2025 9:23am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jan 7, 2025 9:23am

Copy link

pkg-pr-new bot commented Jan 7, 2025

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1566

@shopware-pwa/cms-base

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/cms-base@1566

@shopware-pwa/composables-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/composables-next@1566

@shopware-pwa/helpers-next

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/helpers-next@1566

@shopware-pwa/nuxt3-module

npm i https://pkg.pr.new/shopware/frontends/@shopware-pwa/nuxt3-module@1566

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1566

commit: f0328ba

Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #1566 will degrade performances by 37.87%

Comparing feat/multiple-patch-files (f0328ba) with main (87610c0)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 2 improvements
❌ 6 (👁 6) regressions
✅ 1 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/multiple-patch-files Change
👁 [api-client][createAPIClient] - creating client 121.2 µs 195 µs -37.87%
👁 [api-client][createAdminAPIClient] - creating client 153.2 µs 209.8 µs -27%
👁 [api-client][transformPathToQuery] - transform with body params 66.6 µs 97.4 µs -31.57%
👁 [api-client][transformPathToQuery] - transform with header params 80.7 µs 92.2 µs -12.47%
[api-client][transformPathToQuery] - transform with path params 387.9 µs 89 µs ×4.4
👁 [api-client][transformPathToQuery] - transform with path,query,body,header params 83.1 µs 118.9 µs -30.15%
👁 [api-client][transformPathToQuery] - transform with query params 65.8 µs 98.9 µs -33.45%
[api-client][transformPathToQuery] - transform without any params 133.4 µs 84.9 µs +57.13%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant