Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trusted proxies configurable by env TRUSTED_PROXIES #79

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

pweyck
Copy link
Contributor

@pweyck pweyck commented Jan 24, 2024

No description provided.

@pweyck pweyck requested review from shyim and philipreinken January 24, 2024 12:37
Copy link

github-actions bot commented Jan 24, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Add the Shopware flex endpoint in your composer.json to https://raw.githubusercontent.com/shopware/recipes/flex/pull-79/index.json.

    # When jq is installed
    jq '.extra.symfony.endpoint |= [ "https://raw.githubusercontent.com/shopware/recipes/flex/pull-79/index.json" ] + .' composer.json > composer.tmp && mv composer.tmp composer.json

    or manually

    "endpoint": [
        "https://raw.githubusercontent.com/shopware/recipes/flex/pull-79/index.json",
        "https://raw.githubusercontent.com/shopware/recipes/flex/main/index.json",
        "flex://defaults"
    ]
  2. Install the package(s) related to this recipe:

    composer req 'shopware/docker:^0.1'

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@mitelg mitelg force-pushed the add-trusted-proxies branch from 58661f6 to a516e78 Compare January 24, 2024 12:46
@pweyck pweyck force-pushed the add-trusted-proxies branch 2 times, most recently from d5b5db1 to 3ccf22f Compare January 24, 2024 12:58
@pweyck pweyck force-pushed the add-trusted-proxies branch from 3ccf22f to 1d9adca Compare January 24, 2024 13:03
@pweyck pweyck merged commit 7379a1d into main Jan 24, 2024
2 checks passed
@pweyck pweyck deleted the add-trusted-proxies branch January 24, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants