Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): support :bdelete #281

Merged
merged 6 commits into from
Dec 12, 2023
Merged

feat(api): support :bdelete #281

merged 6 commits into from
Dec 12, 2023

Conversation

shortcuts
Copy link
Owner

@shortcuts shortcuts commented Dec 10, 2023

📃 Summary

closes #243 #280

because :bd closes the window the buffer is attached to, we need to provide a custom way to fallback to an other window. As of now, the solution is opt-in because it might not be perfect, but should still cover many use cases.

In order to use this feature, a user must set fallbackOnBufferDelete = true

@shortcuts shortcuts self-assigned this Dec 10, 2023
@shortcuts shortcuts changed the title feat(commands): support :bdelete feat(api): support :bdelete Dec 10, 2023
@shortcuts shortcuts marked this pull request as ready for review December 12, 2023 20:59
@shortcuts shortcuts merged commit ba409c3 into main Dec 12, 2023
6 of 7 checks passed
@shortcuts shortcuts deleted the feat/support-bd-command branch December 12, 2023 21:20
shortcuts pushed a commit that referenced this pull request Dec 13, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.7.0](v1.6.3...v1.7.0)
(2023-12-13)


### Features

* **api:** support :bdelete
([#281](#281))
([ba409c3](ba409c3))


### Bug Fixes

* **hl:** prevent global highlights
([#283](#283))
([938d8ea](938d8ea))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buffer delete command does not work
1 participant