-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow alphanumeric characters in SQLLite style parameters. #32
Merged
shssoichiro
merged 18 commits into
shssoichiro:master
from
BlurrechDev:allow-alphanumeric-parameters
Dec 5, 2023
Merged
Allow alphanumeric characters in SQLLite style parameters. #32
shssoichiro
merged 18 commits into
shssoichiro:master
from
BlurrechDev:allow-alphanumeric-parameters
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exed parameters exist.
…oichiro#31) 1e16 and 1e+!6 are both valid. Co-authored-by: Paul Roskell <[email protected]>
The code looks good. Would you be able to run |
* treat $$ as a reserved token that sits on its own line * format BEGIN and DECLARE for plpgsql --------- Co-authored-by: Josh Holmer <[email protected]>
…exed parameters exist.
…der tokens after reserved word tokens.
…urrechDev/sqlformat-rs into allow-alphanumeric-parameters
@shssoichiro Sorted. I had to rejig the token ordering so this would play nicely with the very recent $$ change. |
Thanks for these @BlurrechDev @shssoichiro if you'd be up for doing a release, I'd love to integrate this into PRQL |
Published, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #18
I don't have a Rust background so there may be better ways of doing this.
Happy to adjust as necessary or throw out the lot as it may be.
Thanks.