Skip to content

Commit

Permalink
retire the BrowserManager
Browse files Browse the repository at this point in the history
This is because it has been creating resources and not disposing of them correctly.

It also was doing things that can be done natively with pytest without the extra classes & imports
  • Loading branch information
shtlrs committed Mar 23, 2024
1 parent cb8dfd2 commit ae72244
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 30 deletions.
17 changes: 0 additions & 17 deletions test/e2e/playwright/browser_manager.py

This file was deleted.

7 changes: 3 additions & 4 deletions test/e2e/testscenarios/test_copy_paste.py
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import pytest
from playwright.sync_api import Playwright
from playwright.sync_api import Page

from test.conftest import make_screenshot
from test.e2e.pageobjects.create_paste_page import CreatePastePage
from test.e2e.pageobjects.view_paste_page import ViewPastePage
from test.e2e.utils.clipboard_utils import verify_clipboard_contents
from test.e2e.playwright.browser_manager import BrowserManager


@pytest.mark.e2e
def test_copy_paste(playwright: Playwright, request):
@pytest.mark.browser_type_launch_args(headless=False)
def test_copy_paste(page: Page, request):
# This test needs to be run in a headed mode for the clipboard to work correctly
page = BrowserManager(playwright).create_new_context(headless=False)
try:
create_paste_page = CreatePastePage(page)
create_paste_page.open()
Expand Down
16 changes: 7 additions & 9 deletions test/e2e/testscenarios/test_create_paste.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
from test.e2e.conftest import create_paste_page
from test.e2e.pageobjects.create_paste_page import CreatePastePage
from test.e2e.pageobjects.view_paste_page import ViewPastePage
from test.e2e.playwright.browser_manager import BrowserManager

import pytest
from playwright.sync_api import Page, Playwright
from playwright.sync_api import Page


@pytest.mark.e2e
def test_create_single_paste(
page: Page, playwright: Playwright, create_paste_page: CreatePastePage
page: Page, create_paste_page: CreatePastePage
):
create_paste_page.should_have_title("Create new paste")

Expand All @@ -21,12 +20,12 @@ def test_create_single_paste(
view_paste_page.should_have_pasted_text(pasted_text)

paste_url = view_paste_page.current_url()
reopen_created_paste(playwright, paste_url)
reopen_created_paste(page, paste_url)


@pytest.mark.e2e
def test_create_multi_paste(
page: Page, playwright: Playwright, create_paste_page: CreatePastePage
page: Page, create_paste_page: CreatePastePage
):
first_pasted_text = create_paste_page.paste_random_text(paste_number=0)
create_paste_page.click_add_another_file_button()
Expand All @@ -45,11 +44,10 @@ def test_create_multi_paste(
view_paste_page.should_have_pasted_text(third_pasted_text, paste_number=2)

paste_url = view_paste_page.current_url()
reopen_created_paste(playwright, paste_url)
reopen_created_paste(page, paste_url)


def reopen_created_paste(playwright, paste_url):
new_page = BrowserManager(playwright).create_new_context()
new_view_paste_page = ViewPastePage(new_page)
def reopen_created_paste(page: Page, paste_url):
new_view_paste_page = ViewPastePage(page)
new_view_paste_page.open(paste_url)
new_view_paste_page.should_be_opened()

0 comments on commit ae72244

Please sign in to comment.