Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CMake builds #73

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

improve CMake builds #73

wants to merge 8 commits into from

Conversation

DDvO
Copy link
Member

@DDvO DDvO commented Jan 9, 2025

  • CMakeLists.txt: must do add_compile_options() before add_library() and add_executable()
  • README.md: streamline the texts and subsection structure
  • CMakeLists.txt: improve 'uninstall' target
  • CMakeLists.txt:,Makefile_v1,README.md: for consistency, take /usr/local as installation target
  • CMakeLists.txt´: improve 'clean_all'` target

@DDvO DDvO force-pushed the improve_CMake_builds branch from d0dea4e to aaee01e Compare January 9, 2025 16:05
@DDvO DDvO requested review from rajeev-0 and removed request for rajeev-0 January 9, 2025 16:38
@DDvO DDvO marked this pull request as draft January 9, 2025 19:16
Copy link
Collaborator

@rajeev-0 rajeev-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DDvO DDvO force-pushed the improve_CMake_builds branch 3 times, most recently from 2d65ed5 to 63368cb Compare January 10, 2025 21:00
@DDvO DDvO force-pushed the improve_CMake_builds branch from 63368cb to b1d0f87 Compare January 10, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants