Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover scripts after ref-index.so removal #23

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

marcows
Copy link
Contributor

@marcows marcows commented Nov 4, 2022

The permuted index had been removed in commit 4ae29d8 ("Remove secondary index from reference manual. Remove Warnings.", 2022-10-28) and further cleaned up in commit ad1d6f3 ("Remove vestigal ref_index.so (#22)", 2022-11-04).

See also issue #21.

The permuted index had been removed in commit 4ae29d8 ("Remove
secondary index from reference manual. Remove Warnings.", 2022-10-28)
and further cleaned up in commit ad1d6f3 ("Remove vestigal
ref_index.so (sierrafoxtrot#22)", 2022-11-04).

See also issue sierrafoxtrot#21.
@sierrafoxtrot
Copy link
Owner

Hi Markus, shouldn't be any issues with this. I'll queue it up behind @jtxa's PR #19 which is almost complete. It's pretty big and touches on the same areas so just wanting to simplify the merge.

@marcows
Copy link
Contributor Author

marcows commented Nov 4, 2022

Well, I just saw that my change is part of PR #19 in commit d2ff456, but yet again cleanup is not complete.

@jtxa
Copy link
Contributor

jtxa commented Nov 4, 2022

Please merge this PR first. I'll rebase mine again and try to improve it based on @marcows comments.

@sierrafoxtrot sierrafoxtrot merged commit 0a64015 into sierrafoxtrot:master Nov 4, 2022
@marcows marcows deleted the ref-index-leftover branch November 4, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants