Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Windows MSYS2, MacOS and QA workflow #24

Merged
merged 4 commits into from
Nov 5, 2022

Conversation

jtxa
Copy link
Contributor

@jtxa jtxa commented Nov 5, 2022

Additionally to the Linux builds, there's now also one on MacOS, and 3 MSYS2 based on Windows.
Also a minimal clang-tidy configuration and check was added.

jtxa added 4 commits November 5, 2022 00:52
Use `apt-get` instead of `apt`.
Avoids a warning that `apt` is not suitable for automation.

Use single installation call to avoid ignored exit code.

Add separate steps for smoke test and test preparation.

Remove permissions settings which were needed for the remove test report.

Explicit setting of shell is not necessary anymore, the tests run fine
on Ubuntu without it.
Maybe the addition of the executable flags or fixing the `shellcheck`
issues helped. These were done in previous commits.
Also move the documentation generation to QA.
Add minimal example configuration.
@jtxa
Copy link
Contributor Author

jtxa commented Nov 5, 2022

FYI: Windows needs about 7, MacOS about 6 minutes. In comparison, Linux is about 1 and a half.

@jtxa jtxa mentioned this pull request Nov 5, 2022
43 tasks
@sierrafoxtrot
Copy link
Owner

All looks great. I've been scratching my head on how to do the mac build (I don't own one and was looking on ebay for something cheap...).

One overall comment is that I've been considering switching the default generator to ninja everywhere (rather than make on Linux for example). Any thoughts? Would including it here make sense given all the spots where you need to explicitly run cmake -G ninja?

@jtxa
Copy link
Contributor Author

jtxa commented Nov 5, 2022

All the workflows use Ninja already. It's what I always use in combination with CMake (has its benefits, although maybe not relevant for SRecord).
I don't think there are any other calls inside the repo, apart from the BUILDING.man documentation.

Inside the cmake files you should not set a default generator, it's not really possible and the decision is up to the user.
Personally you can specify it in a CMAKE_GENERATOR environment variable, so you don't need to specify it yourself on the command line every time.

@sierrafoxtrot
Copy link
Owner

Inside the cmake files you should not set a default generator, it's not really possible and the decision is up to the user.

Fair call. It's my preference too but no reason to try to impose that on others (even if it were possible).

@sierrafoxtrot sierrafoxtrot merged commit f8bbb88 into sierrafoxtrot:master Nov 5, 2022
@jtxa jtxa deleted the ci-win-mac branch November 5, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants