CI: Fail QA on warnings by clang-14 and gcc-11 #27
Conversation
Contrary to C++17 a message is needed for C++11. clang++ warning: ~~~ static_assert with no message is a C++17 extension [-Wc++17-extensions] ~~~
VLA is a feature of C99 which is not available in C++11 or even later. Avoid using this non-standard extension. clang++ warning: ~~~ variable length arrays are a C99 feature [-Wvla-extension] ~~~
The function `starts_with` is only used inside `assert` calls. In case of release builds it is unused. Add a preprocessor condition to activate it only when needed. g++ warning: ~~~ warning: ‘bool starts_with(const string&, const string&)’ defined but not used [-Wunused-function] ~~~
clang++ warning: ~~~ note: hidden overloaded virtual function 'srecord::output::write_data' declared here: different number of parameters (3 vs 1) ~~~
clang++ warning: ~~~ warning: unused parameter 'cmdln' [-Wunused-parameter] ~~~
Do a build with `-std=c++11 -pedantic -Wall -Wextra` enabled for clang and gcc. Use `-Werror` to abort on any warning. But let build keep going by calling `ninja -k 0` and not abort on the first file with errors.
jtxa
force-pushed
the
ci-abort-on-warnings
branch
from
0660c10 to
66e7d44
Compare
|
Moved new/delete out of for-loop. Force pushed. |
|
I assume that all new/delete call in SRecord may be replaced by something more modern; smart pointers and their helper functions or so. At least RAII shall be used, RAII may also be useful elsewhere (I haven't looked how files are opened/closed). But I did not invest any time on that for now, because this change should be simple & straight forward so we can enforce warning free check soon. |
Totally agree with this. Happy to look into RAII and other more modern approaches if there is a solid reason to rewrite. Let's chat! |
|
I stupidly hit close (facepalm). Merging now |
Fixed most warnings for
-std=c++11 -pedantic -Wall -Wextra.Disabled only
-Wno-implicit-fallthroughon gcc for now.info for older gcc,
-pedanticmay throw more messages: gcc-8 doesn't like the extra ; on the end of namespace.Added a gcc-11 build to QA workflow, enabled
-Werrorfor it and clang. Added-k 0to ninja call, to keep it compiling all files.write_record_datamatches quite well the function directly about itwrite_record_header.