Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @marcows the documentation should be built on MSYS2 to make sure, that it works in this environment.
The workflow now includes a build
all
after doing the tests.Packaging the zip and upload it as artifact was added as bonus.
The WIX package had several error messages, so that's out of scope for this PR.
As the documentation build did not work, I first splitted the PDF generation into 3 separate step, to be absolutely sure, that the groff call fails.
The only functional change of that split is, that the groff generated ps file is now kept instead of being deleted.
The observed problem was, that the file to be included by groff/soelim contained the carriage return as part of its filename.
This must be caused by the workflows checkout actions, which most probably uses Git for Windows which does CRLF checkouts by default.
To be independent from user git settings, this PR also includes a
.gitattribute
file that explicitly sets LF eol for all files processed by groff. Also the shell and awk scripts shall use always LF.Editorconfig has been updated to match that behaviour.