Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix #33

Merged
merged 3 commits into from
Jan 22, 2023
Merged

CI fix #33

merged 3 commits into from
Jan 22, 2023

Conversation

jtxa
Copy link
Contributor

@jtxa jtxa commented Jan 15, 2023

Updated MegaLinter brings:

  • a new ShellCheck, that issues an error: Fixed by modifying a few test shell scripts.
  • cSpell filename check: Fixed by added some words as expetions

Linux runners were also failing, but that was only temporarily.
Nonetheless do an apt-get update as advised by the GitHub docs.

jtxa added 3 commits January 15, 2023 13:30
This warning occurs:

~~~
  test $? -eq 0 || no_result
       ^-- SC2320 (warning): This $? refers to echo/printf, not a previous command. Assign to variable to avoid it being overwritten.
~~~

See https://www.shellcheck.net/wiki/SC2320 for details.

But in this case the return code of echo is really checked:
to make sure that the file redirection worked.

To avoid the, otherwise useful, ShellCheck warning,
simply pipe through `cat` for these cases.
MegaLinter v6.14.0 does also check file name spelling.
This was referenced Jan 15, 2023
@sierrafoxtrot sierrafoxtrot merged commit 72df932 into sierrafoxtrot:master Jan 22, 2023
@jtxa jtxa deleted the ci-fix branch January 22, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants