Modernization/updating c++ pass 1

.clang-tidy

@@ -42,8 +42,8 @@ Checks: >-
   -modernize-avoid-c-arrays,
   -modernize-loop-convert,
   -modernize-use-default-member-init,
-  -modernize-use-equals-default,
-  -modernize-use-equals-delete,
+  modernize-use-equals-default,
+  modernize-use-equals-delete,
   -modernize-use-nullptr,
   -modernize-use-override,
   -performance-unnecessary-copy-initialization,
@@ -59,7 +59,6 @@ Checks: >-
   -readability-named-parameter,
   -readability-redundant-member-init,
   -readability-redundant-string-init,
-
 # All enabled checks shall be reported as error.
 WarningsAsErrors: "*"
 

doc/dictionaries/names.txt

@@ -108,6 +108,7 @@ Sadowski
 Schmitt
 SDSMAC
 Sean
+SeanAlling-DojoFive
 segfault
 Seitz
 Sergeev

srec_cat/arglex3.cc

@@ -51,8 +51,3 @@ srec_cat_arglex3::srec_cat_arglex3(int argc, char **argv) :
 
     table_set(table);
 }
-
-
-srec_cat_arglex3::~srec_cat_arglex3()
-{
-}

srec_cat/arglex3.h

@@ -46,28 +46,38 @@ class srec_cat_arglex3:
     /**
       * The destructor.
       */
-    virtual ~srec_cat_arglex3();
+    ~srec_cat_arglex3() override = default;
 
     /**
       * The constructor.
       */
     srec_cat_arglex3(int, char **);
 
-private:
     /**
-      * The default constructor.  Do not use.
+      * The default constructor.
       */
-    srec_cat_arglex3();
+    srec_cat_arglex3() = delete;
 
     /**
-      * The copy constructor.  Do not use.
+      * The copy constructor.
       */
-    srec_cat_arglex3(const srec_cat_arglex3 &);
+    srec_cat_arglex3(const srec_cat_arglex3 &) = delete;
 
     /**
-      * The assignment operator.  Do not use.
+      * The assignment operator.
       */
-    srec_cat_arglex3 &operator=(const srec_cat_arglex3 &);
+    srec_cat_arglex3 &operator=(const srec_cat_arglex3 &) = delete;
+
+    /**
+      * The move constructor
+      */
+    srec_cat_arglex3 ( srec_cat_arglex3 && ) = delete;
+
+    /**
+      * The move assignment operator
+      */
+    srec_cat_arglex3& operator=(srec_cat_arglex3&&) = delete;
+
 };
 
 #endif // PROG_SREC_CAT_ARGLEX3_H

srecord/adler16.cc

@@ -18,38 +18,6 @@
 
 #include <srecord/adler16.h>
 
-
-srecord::adler16::~adler16()
-{
-}
-
-
-srecord::adler16::adler16() :
-    sum_a(1),
-    sum_b(0)
-{
-}
-
-
-srecord::adler16::adler16(const adler16 &rhs) :
-    sum_a(rhs.sum_a),
-    sum_b(rhs.sum_b)
-{
-}
-
-
-srecord::adler16 &
-srecord::adler16::operator=(const adler16 &rhs)
-{
-    if (this != &rhs)
-    {
-        sum_a = rhs.sum_a;
-        sum_b = rhs.sum_b;
-    }
-    return *this;
-}
-
-
 unsigned short
 srecord::adler16::get()
     const

srecord/adler16.h

@@ -32,26 +32,6 @@ namespace srecord
 class adler16
 {
 public:
-    /**
-      * The destructor.
-      */
-    virtual ~adler16();
-
-    /**
-      * The default constructor.
-      */
-    adler16();
-
-    /**
-      * The copy constructor.
-      */
-    adler16(const adler16 &);
-
-    /**
-      * The assignment operator.
-      */
-    adler16 &operator=(const adler16 &);
-
     /**
       * The get method is used to obtain the running value of the checksum.
       */
@@ -72,13 +52,13 @@ class adler16
       * The sum_a instance variable is used to remember the sum of bytes
       * scanned.
       */
-    unsigned char sum_a;
+    unsigned char sum_a{1};
 
     /**
       * The sum_b instance variable is used to remember the sum of the
       * sum of bytes scanned.
       */
-    unsigned char sum_b;
+    unsigned char sum_b{0};
 };
 
 };

srecord/adler32.cc

@@ -18,38 +18,6 @@
 
 #include <srecord/adler32.h>
 
-
-srecord::adler32::~adler32()
-{
-}
-
-
-srecord::adler32::adler32() :
-    sum_a(1),
-    sum_b(0)
-{
-}
-
-
-srecord::adler32::adler32(const adler32 &rhs) :
-    sum_a(rhs.sum_a),
-    sum_b(rhs.sum_b)
-{
-}
-
-
-srecord::adler32 &
-srecord::adler32::operator=(const adler32 &rhs)
-{
-    if (this != &rhs)
-    {
-        sum_a = rhs.sum_a;
-        sum_b = rhs.sum_b;
-    }
-    return *this;
-}
-
-
 unsigned long
 srecord::adler32::get()
     const

srecord/adler32.h

@@ -34,26 +34,6 @@ namespace srecord
 class adler32
 {
 public:
-    /**
-      * The destructor.
-      */
-    virtual ~adler32();
-
-    /**
-      * The default constructor.
-      */
-    adler32();
-
-    /**
-      * The copy constructor.
-      */
-    adler32(const adler32 &);
-
-    /**
-      * The assignment operator.
-      */
-    adler32 &operator=(const adler32 &);
-
     /**
       * The get method is used to obtain the running value of the
       * checksum.
@@ -75,13 +55,13 @@ class adler32
       * The sum_a instance variable is used to remember the sum of bytes
       * scanned.
       */
-    unsigned short sum_a;
+    unsigned short sum_a{1};
 
     /**
       * The sum_b instance variable is used to remember the sum of the
       * sum of bytes scanned.
       */
-    unsigned short sum_b;
+    unsigned short sum_b{0};
 };
 
 };

srecord/arglex.cc

@@ -49,15 +49,13 @@ static const srecord::arglex::table_ty default_table[] =
 };
 
 
-srecord::arglex::arglex() :
-    usage_tail_(0)
+srecord::arglex::arglex()
 {
     table_set(default_table);
 }
 
 
-srecord::arglex::arglex(int ac, char **av) :
-    usage_tail_(0)
+srecord::arglex::arglex(int ac, char **av)
 {
     progname_set(av[0]);
     for (int j = 1; j < ac; ++j)
@@ -131,11 +129,6 @@ srecord::arglex::read_arguments_file(const char *filename)
 }
 
 
-srecord::arglex::~arglex()
-{
-}
-
-
 void
 srecord::arglex::table_set(const table_ty *tp)
 {

srecord/arglex.h

@@ -41,7 +41,33 @@ class arglex
     /**
       * The destructor.
       */
-    virtual ~arglex();
+    virtual ~arglex() = default;
+
+    /**
+      * The default constructor.
+      */
+    arglex();
+
+    /**
+      * The copy constructor.
+      */
+    arglex(arglex &) = default;
+
+    /**
+      * The move constructor
+      */
+    arglex ( arglex && ) = default;
+
+    /**
+      * The move assignment operator
+      */
+    arglex& operator=(arglex&&) = default;
+
+    /**
+      * The normal constructor.  The argv and argv should be those
+      * passed to main().  Not manipulation is required.
+      */
+    arglex(int argc, char **argv);
 
     /**
       * The "normal" command line tokens common to all programs.
@@ -169,7 +195,7 @@ class arglex
       * The token instance variable tracks the current token in the
       * parse sequence.
       */
-    int token;
+    int token{};
 
     /**
       * The value_string_ instance variable tracks the value of the
@@ -182,7 +208,7 @@ class arglex
       * of the current command line argument.  Usually zero unless
       * the current command line argument is a number.
       */
-    long value_number_;
+    long value_number_{};
 
     /**
       * The table_ptr_vec_t type is used to declare the 'tables'
@@ -215,22 +241,6 @@ class arglex
     void table_set(const table_ty *);
 
 public:
-    /**
-      * The default constructor.
-      */
-    arglex();
-
-    /**
-      * The copy constructor.
-      */
-    arglex(arglex &);
-
-    /**
-      * The normal constructor.  The argv and argv should be those
-      * passed to main().  Not manipulation is required.
-      */
-    arglex(int argc, char **argv);
-
     /**
       * The token_cur method is used to get the type of the current
       * token.
@@ -288,7 +298,7 @@ class arglex
     /**
       * The help method is used to print a help message.
       */
-    void help(const char * = 0) const;
+    void help(const char * = nullptr) const;
 
     /**
       * The version method is used to print a version message.
@@ -326,7 +336,7 @@ class arglex
       * the command line printed by the 'usage' method.
       * Defaults to the empty string.
       */
-    mutable const char *usage_tail_;
+    mutable const char *usage_tail_{nullptr};
 
     /**
       * The usage_tail_get method is used to get the tail end of

srecord/arglex/tool.cc

@@ -24,12 +24,7 @@
 
 
 srecord::arglex_tool::arglex_tool(int argc, char **argv) :
-    arglex(argc, argv),
-    stdin_used(false),
-    stdout_used(false),
-    issue_sequence_warnings(-1),
-    redundant_bytes(srecord::defcon_warning),
-    contradictory_bytes(srecord::defcon_fatal_error)
+    arglex(argc, argv)
 {
     static const table_ty table[] =
     {
@@ -255,11 +250,6 @@ srecord::arglex_tool::arglex_tool(int argc, char **argv) :
 }
 
 
-srecord::arglex_tool::~arglex_tool()
-{
-}
-
-
 bool
 srecord::arglex_tool::can_get_number()
     const