Migrated code base to use cstdint #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanAlling-DojoFive
force-pushed
the
modernization/use-standard-int
branch
from
da88b66 to
cead6ba
Compare
|
I've been both dreading and looking forward to this change. I actually have a very similar looking branch parked ready to rebase after PR #43 but this looks great so far. I've only done a quick scan so far, but I'm happy with the approach. Keen to make sure we don't cause any drams with doco etc for a couple changes (for example) from %lu to %u. But in principle, I like the more modern types and it can only help with portability. It's going to take a few days to pour through and highlight any discussion points so please bear with me. Keen to get your input too @jtxa. It's moments like these I'm grateful for a regression test suite! |
SeanAlling-DojoFive
changed the title
sierrafoxtrot
requested changes
Mar 5, 2023
SeanAlling-DojoFive
force-pushed
the
modernization/use-standard-int
branch
from
a959e37 to
f25f2fd
Compare
sierrafoxtrot
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at using standard types. Looking for feedback if this is something we want to pursue and how far to go.
Addressed comments in #25 and #26