Add support for gowin .fs files (input only) #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcows
suggested changes
Apr 11, 2023
sierrafoxtrot
requested changes
Apr 13, 2023
There was a problem hiding this comment.
Looks good @danselmi! Why do these vendors all generate their own slightly different file format?!?! But wonderful that you've added this one too.
Please take a look at the "new file format" section of the reference manual. Includes files to update to ensure that --guess option works for your new format as well as the website and libsrecord etc.
This new_file_format.so actually needs another cleanup (on my todo list) so please let me know if I can help.
Add support for gowin .fs files (input only) . Includes implementation, documentation and regression test.
|
I hope that I caught all spots which needed adjustments. |
sierrafoxtrot
approved these changes
Apr 14, 2023
|
Looks good Daniel. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for gowin .fs files (input only) . Includes implementation, documentation and regression test.