Add 'extern' to all declarations to allow -fno-common option #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is required to resolve sifive/freedom-metal#229 |
|
We are planning to cut a branch today/tomorrow. This should go after the branch is pulled, and if needed we can cherry-pick it into the release branch. |
Agreed. This is not required when using gcc 8.3 as that uses -fcommon by default. Just getting ready for this to be merged after the release. |
-fno-common requires there to be only one definition of each global symbol, with other usages being 'extern' declarations. This provides compatibility with GCC 10 where -fno-common is now the default. Signed-off-by: Keith Packard <[email protected]> --- v2: Fix code formatting
| @@ -247,15 +247,15 @@ std::string Device::platform_define_offset(node n, std::string suffix) { | |||
| * "__metal_" namespace */ | |||
| void Device::emit_struct_decl(std::string type, const node &n) { | |||
| emit_comment(n); | |||
| os << "struct __metal_driver_" << type << " __metal_dt_" << n.handle() | |||
| << ";\n\n"; | |||
| os << "extern /* hello */ struct __metal_driver_" << type << " __metal_dt_" | |||
There was a problem hiding this comment.
What's the /* hello */ for?
|
Just for debugging! Good catch
…On Tue, May 12, 2020, 14:50 Nathaniel Graff ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In metal_header/device.c++
<#220 (comment)>
:
> @@ -247,15 +247,15 @@ std::string Device::platform_define_offset(node n, std::string suffix) {
* "__metal_" namespace */
void Device::emit_struct_decl(std::string type, const node &n) {
emit_comment(n);
- os << "struct __metal_driver_" << type << " __metal_dt_" << n.handle()
- << ";\n\n";
+ os << "extern /* hello */ struct __metal_driver_" << type << " __metal_dt_"
What's the /* hello */ for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#220 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG3ASERCYQCHLX3OBLN6S3RRHADJANCNFSM4M3QBVNA>
.
|
Merged
|
Duplicate of PR#222, that has been validated on freedom-e-sdk and PCS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fno-common requires there to be only one definition of each global
symbol, with other usages being 'extern' declarations. This provides
compatibility with GCC 10 where -fno-common is now the default.
Signed-off-by: Keith Packard [email protected]