Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor make render to support rendering TLS certificates #1638

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

jvoravong
Copy link
Contributor

Description:
These changes do not affect the customer directly and only make our CI/CD code more flexible in preparation for upcoming changes.

  • Refactor make render to handle TLS certificate rendering in a way that doesn't break CI/CD checks.
    • For upcoming work, certificates will be generated in the rendered manifest content. Since each make render execution generates unique certificate values, this could cause CI/CD checks to fail.
    • To resolve this, we redacted unique certificate values and updated the linting rules to ignore files containing TLS certificates (e.g., operator-webhook.yaml).
  • Moved render-examples.sh to reside under ./ci_scripts/ because it really belongs there at this point.
  • Abstracted the TLS redaction logic into a reusable utility function for both the make render action and thesplunk_kubernetes_debug_info.sh script to use.

…a way that doesn't break CI/CD checks. Certificates would generate a unique values per `make render` execution, we updated the unique values to be redacted and link rules to ignore checking files where TLS certificates exists.
@jvoravong jvoravong marked this pull request as ready for review January 30, 2025 16:03
@jvoravong jvoravong requested review from a team as code owners January 30, 2025 16:03
@jvoravong jvoravong merged commit 56f18c7 into main Jan 30, 2025
64 of 65 checks passed
@jvoravong jvoravong deleted the otel-2900-ci branch January 30, 2025 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants