Proposal for pay() and NewOwnerEvent tracking #21
Conversation
Changing pay() and newOwnerEvent
Only send message stop selling if status on sale or auction
| @@ -282,10 +285,9 @@ public void txReceived() { | |||
| if (getCurrentTxAmount() >= currentPrice) { | |||
| // Conditions match, let's execute the sale | |||
| pay(); // pay the current owner | |||
| sendMessage(getCurrentTxSender().getId(), getCurrentTxAmount(), owner.getId(),trackNewOwner); | |||
There was a problem hiding this comment.
So the idea is to also send the previous owner to the tracker?
There was a problem hiding this comment.
I'm very concerned about this change, as this has a significant impact on development and the system. Accepting this change will break with the plan to roll out in the beginning of the next week. The change affects a lot of parts of the system. Probably, it's better to keep this change in the backlog and apply once we find more issues.
From my understanding this is just a minor enhancement on state reporting, rather than an issue. The moment that this proposal comes up is not chosen wisely. I'm opposed to the change...and prefer to patch the reporting on the front end, which is comparatively very easy without any significant impact.
|
I can see your concern, but we have two parts Part i - avoid notForSale message Part Il - we are only setting the newOwnwer and Price in the message. We should also fill up accountid2 on the DB - open for any other proposal as adding it to attribute3 in the message Part I is not impacting the portal setup at all - from my point of view - we have just less events. Part II - adding a new attribute to the message as attribute3 - can this be ignored by the processor at the beginning ? Not clear for me - if yes we could go live without processing the new value |
Avoding to create an offer when auction is running
A new standard for Liquidity Pool Contracts
to discuss