Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some sync/backfill format nits #6861

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Some sync/backfill format nits #6861

merged 2 commits into from
Jan 30, 2025

Conversation

dapplion
Copy link
Collaborator

Proposed Changes

When working on unrelated changes I noted:

  • An unnecessary closure left by a commit of some guy named @dapplion that can be removed
  • match statements that can be simplified with the new let else syntax
  • instead of mapping a result to ignore the Ok value, return

@dapplion dapplion requested a review from jxs as a code owner January 24, 2025 17:41
@dapplion dapplion added the ready-for-review The code is ready for review label Jan 25, 2025
michaelsproul
michaelsproul reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just code blocks moving around while retaining the same semantics. Happy to merge as-is or with that extra closure removed

beacon_node/network/src/sync/backfill_sync/mod.rs Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 29, 2025
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 30, 2025
mergify bot added a commit that referenced this pull request Jan 30, 2025
@mergify
Merge of #6861
a1b4488
@mergify mergify bot mentioned this pull request Jan 30, 2025
Closed
6 tasks
@mergify mergify bot merged commit 66c6552 into sigp:unstable Jan 30, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dapplion @michaelsproul