Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the smallvec length for Bitfield #35

Closed
wants to merge 4 commits into from
Closed

Increase the smallvec length for Bitfield #35

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bac5bdc
Pre-allocate len of a fixed vec during Decode
paulhauner Nov 25, 2024
3103ee0
Bump smallvec len
paulhauner Nov 25, 2024
2671609
Merge branch 'main' into bump-smallvec-len
paulhauner Nov 25, 2024
f9cf087
Bump to 128
paulhauner Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/bitfield.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ use typenum::Unsigned;

/// Maximum number of bytes to store on the stack in a bitfield's `SmallVec`.
///
/// The default of 32 bytes is enough to take us through to ~500K validators, as the byte length of
/// attestation bitfields is roughly `N // 32 slots // 64 committes // 8 bits`.
pub const SMALLVEC_LEN: usize = 32;
/// 128 bytes is enough to take us through to ~2M active validators, as the byte
/// length of attestation bitfields is roughly `N // 32 slots // 64 committes //
/// 8 bits`.
pub const SMALLVEC_LEN: usize = 128;

/// A marker trait applied to `Variable` and `Fixed` that defines the behaviour of a `Bitfield`.
pub trait BitfieldBehaviour: Clone {}
Expand Down