Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up to v0.4.0, add changelog #506

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bobcallaway
Copy link
Member

consistently sets all code at v0.4.0 and once merged this commit can be tagged which will trigger the release process

Signed-off-by: Bob Callaway <[email protected]>
@loosebazooka
Copy link
Member

I thought we were keeping the spec version and library version in sync? Although I dunno how that's gonna be reasonable long term

@bobcallaway
Copy link
Member Author

bobcallaway commented Jan 20, 2025

@haydentherapper thoughts?

@kommendorkapten
Copy link
Member

No, the messages and releases are versioned independently, see RELEASE.md

Two of the messages, Bundle and TrustedRoot, are expected to be persisted and serialized to disk, and exchanged via other mechanisms such as the Sigstore TUF root. Therefore they contain a media_type. The media types are versioned, and so they must be updated appropriately according to semver. Each message SHOULD be versioned independently and so MAY differ from the targeted release. The media type represents the version of the message, not the release. Note that the media type does NOT capture the patch version, only major/minor.

@kommendorkapten
Copy link
Member

Should we also remove the reference to JSON Schema in the release steps: https://github.com/sigstore/protobuf-specs/blob/main/RELEASE.md#json-schema

Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bobcallaway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants