-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump up to v0.4.0, add changelog #506
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
I thought we were keeping the spec version and library version in sync? Although I dunno how that's gonna be reasonable long term |
@haydentherapper thoughts? |
No, the messages and releases are versioned independently, see RELEASE.md
|
Should we also remove the reference to JSON Schema in the release steps: https://github.com/sigstore/protobuf-specs/blob/main/RELEASE.md#json-schema |
Signed-off-by: Bob Callaway <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bobcallaway!
consistently sets all code at
v0.4.0
and once merged this commit can be tagged which will trigger the release process