Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Navigation Bar #759

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Conversation

davidmoore1
Copy link
Contributor

No description provided.

@davidmoore1 davidmoore1 marked this pull request as draft December 12, 2024 21:58
@davidmoore1 davidmoore1 marked this pull request as ready for review December 16, 2024 16:30
…ill having the bar across the full bottom. Eliminate unneeded variables.
Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments...

convert/convertConfig.ts Outdated Show resolved Hide resolved
src/lib/components/BottomNavigationBar.svelte Outdated Show resolved Hide resolved
src/lib/components/BottomNavigationBar.svelte Outdated Show resolved Hide resolved
src/lib/components/BottomNavigationBar.svelte Outdated Show resolved Hide resolved
src/lib/components/BottomNavigationBar.svelte Outdated Show resolved Hide resolved
src/routes/plans/+page.svelte Outdated Show resolved Hide resolved
src/routes/text/+page.svelte Outdated Show resolved Hide resolved
src/routes/contents/[id]/+page.svelte Outdated Show resolved Hide resolved
src/routes/about/+page.svelte Outdated Show resolved Hide resolved
src/routes/text/+page.svelte Outdated Show resolved Hide resolved
Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrisvire chrisvire merged commit 42af36a into sillsdev:main Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants