Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(add_brightness_slider): Adds brightness slider for PBs in network based on PB implementation. #48

Closed
wants to merge 1 commit into from

Conversation

caleyg
Copy link

@caleyg caleyg commented Apr 19, 2023

This PR is based on the implementation in the PB interface, which adds the already familiar brightness slider to the FS UI, with tooltips!
Screen Shot 2023-04-18 at 11 02 49 PM

using lodash there is a small delay so we don't spam the PBs with messages by moving the slider around.

yarn run v1.22.19
$ node server
listening on 3001
> Pixelblaze Discovery Server listening on 0.0.0.0: 1889
connected to 10.0.0.35
sending to 10225758 at 10.0.0.35 {"getConfig":true,"listPrograms":true,"sendUpdates":false}
connected to 10.0.0.34
sending to 16573876 at 10.0.0.34 {"getConfig":true,"listPrograms":true,"sendUpdates":false}
sending to 10225758 at 10.0.0.35 {"brightness":0.445}
sending to 16573876 at 10.0.0.34 {"brightness":0.445}
sending to 10225758 at 10.0.0.35 {"brightness":0.145}
sending to 16573876 at 10.0.0.34 {"brightness":0.145}
sending to 10225758 at 10.0.0.35 {"activeProgramId":"9YNBonyhXfyFjpYzJ"}
sending to 16573876 at 10.0.0.34 {"activeProgramId":"9YNBonyhXfyFjpYzJ"}
sending to 10225758 at 10.0.0.35 {"brightness":0.325}
sending to 16573876 at 10.0.0.34 {"brightness":0.325}
sending to 10225758 at 10.0.0.35 {"brightness":0.07}
sending to 16573876 at 10.0.0.34 {"brightness":0.07}
sending to 10225758 at 10.0.0.35 {"brightness":0.21}
sending to 16573876 at 10.0.0.34 {"brightness":0.21}
sending to 10225758 at 10.0.0.35 {"brightness":0.125}
sending to 16573876 at 10.0.0.34 {"brightness":0.125}
sending to 10225758 at 10.0.0.35 {"brightness":0.105}
sending to 16573876 at 10.0.0.34 {"brightness":0.105}
sending to 10225758 at 10.0.0.35 {"brightness":0.225}
sending to 16573876 at 10.0.0.34 {"brightness":0.225}

This PR resolves #46

Since we store brightness levels in localstoraged, based on whats in master currently. When #44 is finally merged in we will need to update this to store the brightness level in the db backend also.

@caleyg caleyg force-pushed the feature/add_brightness_slider branch from fa54137 to 219d0bb Compare April 19, 2023 04:05
@caleyg caleyg closed this Apr 26, 2023
@caleyg
Copy link
Author

caleyg commented Apr 26, 2023

this will be resolved in this PR #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: It would be nice to have a slider that mimics the brightness levels in the PBs implemented in FS
1 participant