Merge changes from xapi-project's fork #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pau Ruiz Safont <[email protected]>
Lost coverage and doc upload Signed-off-by: Pau Ruiz Safont <[email protected]>
On newer distributions this string contains a dot Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
The original fix for this bug has been tested for years, while the one used for upstream doesn't seem to have had that much usage. xapi-project/xen-api@bc053bb Since the original fix needs ocaml 4.05, I used the opportunity to raise the minimum version to 4.08. Signed-off-by: Pau Ruiz Safont <[email protected]>
This does not fix the issue but can mitigate it Signed-off-by: Marcello Seri <[email protected]> This is now needed in case the pointers are NULL. Cherry-picked from xapi-project/xen-api@3f71785 Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Christian Lindig <[email protected]>
Signed-off-by: Christian Lindig <[email protected]>
See yallop/ocaml-ctypes#651 (comment) Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
This is done through flags when no other option seems more sensible (on generated ffi bindings and for repeating actions in tests). The pci_bus_scan could be actually exposed in the Pci library if needed in the future, I don't believe it's worth the effort to expose it if nobody needs it for now. Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fork has been continually used and tested by xenserver, the changes were not initially upstreamed because the library was causing crashes and needed some rapid development loop at the time.
This code is packaged in xapi's opam repo as 1.0.4, you might want to use a higher version: https://github.com/xapi-project/xs-opam/blob/master/packages/xs/pci.v1.0.4/opam
CI status before merging can be seen at https://github.com/psafont/ocaml-pci/actions/runs/3370580595
This might or might not fix ocaml5 compatibility, but it's something that we will tackle if needed