Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify error message when there is a detector count mismatch #1088

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jlashner
Copy link
Contributor

@jlashner jlashner commented Jan 8, 2025

Properly formats error message that occurs when there is a detector count mismatch between manifestdb and obsfiledb and adds some clarifying detail.

This error message quoted in several open issues and discussions:

@mhasself
Copy link
Member

It isn't necessarily the case that such a problem happens when expanding ObsFileDb with the first additional det_info. It could occur elsewhere in the det_info construction chain. So I think more generic "det_info had n_dets={}; after merge has n_dets={}" would be appropriate.

These IncompleteMetadata errors are always caught and re-raised with additional context (so to speak) -- so the actual "metadata" entry that caused the conflict is included in the traceback. (As in the #1078 traceback)

@jlashner
Copy link
Contributor Author

Sure, that broader error message makes sense to me! I modified it to match your wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants