-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Objects and methods to mtpy-v2 and mth5 #352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KernelDataset now has properties for input/output channels that it gets from the dataframe, so should be consistent with the data.
propbably makes sense to keep the option to specify the input/output channels in case you don't want to process a certain channel like hz
updating to main branches for testing
changed mth5 main to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving some methods to MTH5 and mtpy.
aurora.pipelines.run_summary.convert_channel_summary_to_run_summary
tomth5.tables.ChannelTable.to_run_summary
run summary
comes as a DataFrame with duration and there is a convenience property inmth5.MTH5.run_summary
.mth5.__init__
so as to be genericduration
andhas_data
to help with parsing out runs to processaurora.pipelines.run_summary
tomtpy.processing.run_summary
df
setter
[validates the data frame and adds appropriate columns] andgetter
drop_no_data_rows
which useshas_data
column to drop anyFalse
rows.set_sample_rate
to set the sample rate to process and returns a new DataFrame so that you don't have to recompile the run summary from mth5 objects.aurora.timeseries.KernelDataset
tomtpy.processing
_station_id
, local/remote_mth5_path
]processing_id
propertyinput_channels
andoutput_channels
as a propertyaurora.pipelines.run_summary.RunSummary.check_runs_are_valid()
tomth5.timeseries.RunTS
ormth5.groups.Run
Tests
KernelDataset
andRunSummary
tomtpy
in testsKernelDataset
andRunSummary