Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Objects and methods to mtpy-v2 and mth5 #352

Merged
merged 37 commits into from
Aug 28, 2024
Merged

Move Objects and methods to mtpy-v2 and mth5 #352

merged 37 commits into from
Aug 28, 2024

Conversation

kujaku11
Copy link
Collaborator

Moving some methods to MTH5 and mtpy.

  • aurora.pipelines.run_summary.convert_channel_summary_to_run_summary to mth5.tables.ChannelTable.to_run_summary
    • run summary comes as a DataFrame with duration and there is a convenience property in mth5.MTH5.run_summary.
    • The run summary columns and dtypes now live in mth5.__init__ so as to be generic
    • Included in the columns are duration and has_data to help with parsing out runs to process
  • Copy aurora.pipelines.run_summary to mtpy.processing.run_summary
    • Copied over all functionality, type hinting.
    • Added
      • df setter [validates the data frame and adds appropriate columns] and getter
      • drop_no_data_rows which uses has_data column to drop any False rows.
      • set_sample_rate to set the sample rate to process and returns a new DataFrame so that you don't have to recompile the run summary from mth5 objects.
  • Copy aurora.timeseries.KernelDataset to mtpy.processing
    • Add properties for commonly accessed attributes [local/remote_station_id, local/remote_mth5_path]
    • Add methods for validation
    • Add processing_id property
    • Add input_channels and output_channels as a property
  • Move aurora.pipelines.run_summary.RunSummary.check_runs_are_valid() to mth5.timeseries.RunTS or mth5.groups.Run

Tests

  • Change imports of KernelDataset and RunSummary to mtpy in tests
  • Add installation of mtpy into the tests.yml
  • remove tests for KernelDataset and RunSummary

@kkappler kkappler merged commit ea14574 into patches Aug 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants