Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include CarbonAds ad when testing #313

Merged
merged 1 commit into from
Nov 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
210 changes: 112 additions & 98 deletions package-lock.json
11 changes: 6 additions & 5 deletions public/index.pug
Original file line number Diff line number Diff line change
@@ -360,11 +360,12 @@ html(lang=lang)
)
ul.grid
//- This script adds an extra element before itself:
script#_carbonads_js(
async,
src='//cdn.carbonads.com/carbon.js?serve=CKYIPK7M&placement=simpleiconsorg',
type='text/javascript'
)
if !testing
script#_carbonads_js(
async,
src='//cdn.carbonads.com/carbon.js?serve=CKYIPK7M&placement=simpleiconsorg',
type='text/javascript'
)
each icon in icons
//- Using `o="{order-alpha}-{order-color}"` attribute to store ordering data
//- for sorting in order to reduce the size of the DOM.
1 change: 1 addition & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
@@ -434,6 +434,7 @@ export default async (env, argv) => {
languageNames: languageNamesObject,
mode: argv.mode,
xIcon,
testing: process.env.TEST_ENV !== undefined,
},
minify:
argv.mode === 'development'