-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future-proof website for guidelines object format. #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that if design limitations are restricting us to only be able to display one of the guidelines
links for the foreseeable then we should default to the trademark guidelines as they generally have greater legal implications than brand guidelines, and some will often include a link to the brand guidelines. What do you reckon?
Yeah, I can expand it out so that if trademark info is there, that gets shared - otherwise, we show the brand guidelines. |
Co-authored-by: Peter Noble <[email protected]>
Looks like it's failing due to changing the casing of "KinoPoisk" to "Kinopoisk" in #10084. But it's not just failing here, it happened during the build of the site on Sunday, too. |
#317 should fix the issue. |
This PR serves to add some logic around which item we display in the 'guidelines' field. Should mean nothing immediately breaks with the release of PeterShaggyNoble/simple-icons@f26ed39 - and we can adapt to remove the query whenever we decide how we want/need to display trademark notices.