#13779: Decouple docker from maven #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 6, 2024 14:35
igbanam
reviewed
Nov 6, 2024
| @@ -0,0 +1 @@ | |||
| PROJECT_VERSION=0.0.0 | |||
There was a problem hiding this comment.
Looks like you're using this for sane defaults?
There was a problem hiding this comment.
Yes, it's used for defaults only.
igbanam
reviewed
Nov 6, 2024
docker_run/docker-compose.yml
Outdated
| @@ -16,7 +16,7 @@ services: | |||
| retries: 5 | |||
|
|
|||
| prometheusdbexporter: | |||
| image: simpledotorg/prometheusdbexporter:0.0.0 | |||
| image: simpledotorg/prometheusdbexporter:ademarcq-13779.236 | |||
There was a problem hiding this comment.
Does this mean we are fixing all subsequent runs to this version?
There was a problem hiding this comment.
thanks for spotting this.
yes, it should have stayed 0.0.0, I just wrongly committed a file after my local tests
igbanam
requested changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes to "Decouple docker from maven".
Tested locally and with the image added in dockerhub
steps to validate it works:
0.0.0byademarcq-13779.239at line 19