Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ant5 styling #624

Open
wants to merge 21 commits into
base: feature/ant5
Choose a base branch
from
Open

Feature/ant5 styling #624

wants to merge 21 commits into from

Conversation

interim17
Copy link
Contributor

@interim17 interim17 commented Jan 15, 2025 •
edited
Loading

Time estimate or Size

small
hopefully the penultimate PR on this migration

Problem / Solution

Rounding up small styling and functionality fixes for ant migration.

The only thing that I intentionally left unfixed are buttons, which I decided deserved a bigger refactor, in the same vein as DropdownMenuItems. I will PR those changes into this branch.

I made the commit history a bit messy trying to keep various feature branches up to date with main, apologies.

@interim17
bump antd and typescript, and update build tools and components to wo…
ee6d0d7 
…rk with new versions
@interim17
consolidate ts.config
334431a
@interim17
Merge branch 'feature/ant5' of https://github.com/simularium/simulari…
1c629d5 
…um-website into feature/config-provider
@interim17
replace ant-vars.less with ConfigProvider
ad19491
@interim17
semantic color variables names for config provider
2a6b563
@interim17
align css var colors and theme color variables, divide light and dark…
f24d313 
… theme colors
@interim17
consolidate theme variables
58c7ea1
@interim17
styling fixes for antd5
24fd57e
@interim17
fix record icon position
cd63f17
@interim17
merge dropdown button changes
4cb5dec
@interim17
pass onClick into dropdown menu items
eabc972
@interim17
fix meta data panel font sizes
d2f0662
@interim17
fix colorpicker alignment offset
68cbed4
@interim17
remove unused commented style rule
e7b159c
@interim17
remove unused themeConfig
857baef
@interim17
bump viewer version
eaf84b3
@interim17
replace clickHandler with onClick
603b4fa
@interim17
a few more ant migration style fixes
c9c58b1
@interim17
Merge branch 'feature/ant5' of https://github.com/simularium/simulari…
69cd8ef 
…um-website into feature/ant5-styling
@interim17
restore className on dropdown render div
7000cd9
@interim17
remove unused import
205bf25
@interim17 interim17 marked this pull request as ready for review January 15, 2025 21:08
@interim17 interim17 requested a review from a team as a code owner January 15, 2025 21:08
@interim17 interim17 requested review from toloudis and meganrm and removed request for a team January 15, 2025 21:08
toloudis
toloudis approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@toloudis toloudis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a good css reviewer, so you may want to get one more set of eyes on it, but nothing looks too crazy here. Should I be seeing a change in package.json that changes the ant dependency version?

@interim17
Copy link
Contributor Author

I'm not a good css reviewer, so you may want to get one more set of eyes on it, but nothing looks too crazy here. Should I be seeing a change in package.json that changes the ant dependency version?

No, the dependency was bumped already in the target branch, and caused many small styling problems, this is just chasing those down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toloudis toloudis toloudis approved these changes

@meganrm meganrm Awaiting requested review from meganrm meganrm is a code owner automatically assigned from simularium/front-end

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@interim17 @toloudis