Skip to content

Commit

Permalink
Improve TypeScript type for isNonEmptyString() and `isNonEmptyStrin…
Browse files Browse the repository at this point in the history
…gAndNotWhitespace()` (#200)
  • Loading branch information
simPod authored Oct 26, 2023
1 parent f10e2ca commit 0d4cf6f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 3 additions & 2 deletions source/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import type {
Class,
Falsy,
NodeStream,
NonEmptyString,
ObservableLike,
Predicate,
Primitive,
Expand Down Expand Up @@ -582,12 +583,12 @@ export function isNonEmptySet<T = unknown>(value: unknown): value is Set<T> {
}

// TODO: Use `not ''` when the `not` operator is available.
export function isNonEmptyString(value: unknown): value is string {
export function isNonEmptyString(value: unknown): value is NonEmptyString {
return isString(value) && value.length > 0;
}

// TODO: Use `not ''` when the `not` operator is available.
export function isNonEmptyStringAndNotWhitespace(value: unknown): value is string {
export function isNonEmptyStringAndNotWhitespace(value: unknown): value is NonEmptyString {
return isString(value) && !isEmptyStringOrWhitespace(value);
}

Expand Down
2 changes: 2 additions & 0 deletions source/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,5 @@ export type NodeStream = {
} & NodeJS.EventEmitter;

export type Predicate = (value: unknown) => boolean;

export type NonEmptyString = string & {0: string};

0 comments on commit 0d4cf6f

Please sign in to comment.