Skip to content

Commit

Permalink
Updates for python 3.11 (#113)
Browse files Browse the repository at this point in the history
* test on python 3.11

* update pip version and add changelog

* make pylint happy

* correct version in changelog
  • Loading branch information
leslievandemark authored Jan 23, 2024
1 parent e1f418c commit 156c997
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 11 deletions.
11 changes: 5 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,27 @@ orbs:
jobs:
build:
docker:
- image: 218546966473.dkr.ecr.us-east-1.amazonaws.com/circle-ci:stitch-tap-tester
- image: 218546966473.dkr.ecr.us-east-1.amazonaws.com/circle-ci:stitch-tap-tester-3-11-dev
steps:
- checkout
- run:
name: 'Setup virtual env'
command: |
python3 -mvenv /usr/local/share/virtualenvs/tap-bing-ads
source /usr/local/share/virtualenvs/tap-bing-ads/bin/activate
pip install -U 'pip<19.2' 'setuptools<51.0.0'
pip install -U pip 'setuptools<51.0.0'
pip install .[test]
- run:
name: 'pylint'
command: |
source /usr/local/share/virtualenvs/tap-bing-ads/bin/activate
pylint tap_bing_ads -d missing-docstring,line-too-long,invalid-name,super-with-arguments,return-in-init,too-many-arguments,deprecated-method,consider-using-f-string,too-many-lines,unidiomatic-typecheck,consider-using-generator
pylint tap_bing_ads -d missing-docstring,line-too-long,invalid-name,super-with-arguments,return-in-init,too-many-arguments,deprecated-method,consider-using-f-string,too-many-lines,unidiomatic-typecheck,consider-using-generator,broad-exception-raised
- run:
name: 'Unit Tests'
command: |
source /usr/local/share/virtualenvs/tap-bing-ads/bin/activate
pip install nose coverage
nosetests --with-coverage --cover-erase --cover-package=tap_bing_ads --cover-html-dir=htmlcov tests/unittests
coverage html
pip install nose2 parameterized nose2[coverage_plugin]>=0.6.5
nose2 --with-coverage -v -s tests/unittests
- store_test_results:
path: test_output/report.xml
- store_artifacts:
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 2.3.0
*Updates to run on python 3.11.7 [#113](https://github.com/singer-io/tap-bing-ads/pull/113)

## 2.2.1
* Prefer new authentication scope for the access_token request [#99](https://github.com/singer-io/tap-bing-ads/pull/99)

Expand Down
10 changes: 5 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

setup(
name='tap-bing-ads',
version="2.2.1",
version="2.3.0",
description='Singer.io tap for extracting data from the Bing Ads API',
author='Stitch',
url='http://singer.io',
Expand All @@ -15,14 +15,14 @@
# Seems that suds-community is now the reference for 13.0.11.1 so we can install it now with the removal of use_2to3
# https://github.com/BingAds/BingAds-Python-SDK/pull/192
'bingads==13.0.11.1',
'requests==2.20.0',
'singer-python==5.9.0',
'requests==2.31.0',
'singer-python==6.0.0',
'stringcase==1.2.0',
'backoff==1.8.0',
'backoff==2.2.1',
],
extras_require={
'test': [
'pylint==2.14.0'
'pylint==3.0.3'
],
'dev': [
'ipdb'
Expand Down

0 comments on commit 156c997

Please sign in to comment.