-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sum string projection as integer of bool #94
sum string projection as integer of bool #94
Conversation
Hi @rks0nax, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
You did it @rks0nax! Thank you for signing the Singer Contribution License Agreement. |
I need this fix badly. Looks like this has been ready to merge for a long time. What's the hold up? |
@cosimon can you provide an update on this? |
In the Stitch troubleshooting documentation, their recommended course of action for column or table name too long loading errors is to omit the table from the source, rename at the source or switch to a different destination. This PR would allow us to instead use aliases in mongo projections to address the issue, which is MUCH less painful. Switching the destination of our entire data lake is obviously quite painful. Renaming at the source is painful because the source is an app tier DB used in a monolithic architecture -- hard to change. And simply omitting the data obviously only works well if I don't NEED the data in my data lake. Just providing context on why this PR is valuable to me. |
And please notice that the change is:
Seems like it is a no brainer to get this merged. |
Description of change
Fixes issue - #93
The change allows user to specify string projection, instead of just integer values
A sample projection that didn't work before and should be working after merging this PR
{"name": "$personName"}
QA steps
Risks
Rollback steps